| Lists: | pgsql-committers |
|---|
| From: | momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Conditionally output the server version number in psql if it |
| Date: | 2005-09-05 13:59:08 |
| Message-ID: | 20050905135908.9D84BD732B@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Log Message:
-----------
Conditionally output the server version number in psql if it doesn't
exactly match the client version number, and warn about major version
mismatches.
Modified Files:
--------------
pgsql/src/bin/psql:
startup.c (r1.120 -> r1.121)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/startup.c.diff?r1=1.120&r2=1.121)
| From: | Michael Fuhr <mike(at)fuhr(dot)org> |
|---|---|
| To: | Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Conditionally output the server version number in psql if it |
| Date: | 2005-09-05 15:38:14 |
| Message-ID: | 20050905153814.GA64827@winnie.fuhr.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Mon, Sep 05, 2005 at 10:59:08AM -0300, Bruce Momjian wrote:
> Conditionally output the server version number in psql if it doesn't
> exactly match the client version number, and warn about major version
> mismatches.
Any reason not to print a "server version" string that looks like
the actual version? Here's what I get connecting to various servers,
along with the integer that PQserverVersion() returns:
8.0.3 server version 8.03 (80003)
7.4.8 server version 7.48 (70408)
7.3.10 server version 7.3 (70310)
7.2.8 server version 7.28 (70208)
Note in particular the missing minor version when connecting to
7.3.10. Why the inconsistency, and why no dot between major and
minor? Or did I miss that discussion?
--
Michael Fuhr
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Fuhr <mike(at)fuhr(dot)org> |
| Cc: | Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Conditionally output the server version number in psql if it |
| Date: | 2005-09-05 18:06:06 |
| Message-ID: | 2470.1125943566@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Michael Fuhr <mike(at)fuhr(dot)org> writes:
> Note in particular the missing minor version when connecting to
> 7.3.10. Why the inconsistency, and why no dot between major and
> minor? Or did I miss that discussion?
I agree, this is pretty bogus. Cleaned up ...
regards, tom lane