| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | WIN1250 as server encoding |
| Date: | 2004-09-15 15:02:44 |
| Message-ID: | 200409151702.44334.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Some people have requested to add WIN1250 as an allowed server encoding.
So far, the order of the encoding numbers determined which ones were
client-only, so in order not to renumber the encodings, I could only
come up with the attached ugly solution. If no one thinks of a better
one, we'll go with that.
It would also be good if someone who has an environment that calls for
WIN1250 (that is, Windows and an appropriate language environment)
could test whether this actually does anything besides compiling
without errors. :)
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
| Attachment | Content-Type | Size |
|---|---|---|
| win1250.diff | text/x-diff | 2.9 KB |
| From: | "Jeroen T(dot) Vermeulen" <jtv(at)xs4all(dot)nl> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIN1250 as server encoding |
| Date: | 2004-09-15 15:09:50 |
| Message-ID: | 20040915150950.GB45364@xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Sep 15, 2004 at 05:02:44PM +0200, Peter Eisentraut wrote:
> Some people have requested to add WIN1250 as an allowed server encoding.
> So far, the order of the encoding numbers determined which ones were
> client-only, so in order not to renumber the encodings, I could only
> come up with the attached ugly solution. If no one thinks of a better
> one, we'll go with that.
Probably a silly suggestion, but... A second encoding number which happens
to assign the same character codes as WIN1250, with a 1-to-1 translation
table, and renaming the old number to make room for the new one in newly
compiled code?
Jeroen
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIN1250 as server encoding |
| Date: | 2004-09-15 15:21:28 |
| Message-ID: | 4038.1095261688@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Some people have requested to add WIN1250 as an allowed server encoding.
> So far, the order of the encoding numbers determined which ones were
> client-only, so in order not to renumber the encodings, I could only
> come up with the attached ugly solution. If no one thinks of a better
> one, we'll go with that.
Can't we just renumber them?
AFAIR, the only place where these numbers are stored is in
pg_database.datencoding, so only the server-encoding values are frozen
in any meaningful sense. You could rearrange the numbers currently
assigned to client encodings to preserve the range property.
regards, tom lane
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIN1250 as server encoding |
| Date: | 2004-09-15 16:28:06 |
| Message-ID: | 200409151828.06423.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> AFAIR, the only place where these numbers are stored is in
> pg_database.datencoding, so only the server-encoding values are
> frozen in any meaningful sense. You could rearrange the numbers
> currently assigned to client encodings to preserve the range
> property.
Interesting. I guess I was too traumatized by the last numbering change
to ignore that possibility. Does anyone else see a problem with that?
--
Peter Eisentraut
http://developer.postgresql.org/~petere/