Re: Skytools committed without hackers discussion/review

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, "Michael Glaesemann" <grzm(at)seespotcode(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 12:27:17
Message-ID: e51f66da0710100527i3022c9ban67ccacad45547b60@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 10/10/07, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> All objections have been procedural, AFICS.

Lets not talk about mistakes we made for a moment.

And I agree with the rest of the objections in general. But I'd
like to summarise why I still hope the exception can be made
even this late.

This is directly related to attitude to the first submission to 8.2:
"unless Slony uses it we are not interested". Now is the only
moment which won't come again in several years that it's possible
to unify txid handling in Slony and Skytools and also make the
functionality available to broader public.

This due to the fact that Slony 2.0 which will be released with 8.3
will not support PostgreSQL version lower then 8.3.

Yes, we realized the opportunity too late and now it's question
if PostgreSQL is flexible enough to react to this.

Note that rejection now does not cause any big problems to either
Slony and Skytools, we will keep our internal versions of the module,
invisible to anybody else.

But the potential use of the module is huge - it's killer feature is
that it allows to implement high-performance multi-reader / multi-writer
queues inside database. Well, I know this sounds unimpressive, queues
do not belong to standard toolbox when doing database developement.
And those who have tried to implement them, carry a "avoid at any cost" tag,
because thus far there has not been a way to implement robust and
well-perfoming queue inside general-purpose database.

Now txid can change that. E.g. in Skype, it has become irreplaceable
tool for coordinating work between several databases. Here we are
probably going overboard with usage of queues...

--
marko

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-10 12:55:20 Re: Skytools committed without hackers discussion/review
Previous Message Magnus Hagander 2007-10-10 11:50:08 pgsql: Add missing codepage numbers for Windows.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-10-10 12:37:48 Re: Locale + encoding combinations
Previous Message Peter Eisentraut 2007-10-10 12:18:16 Re: Locale + encoding combinations