| From: | Jim Cox <shakahshakah(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |
| Date: | 2009-10-02 22:16:20 |
| Message-ID: | c2ee6dbd0910021516x47dc749bqab37fa5cf5cc1262@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 2, 2009 at 6:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Tom Lane wrote:
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> > Are we sure we don't want a date/time in the ASCII dump? It would
>> > affect database diffs, but I can see it useful too.
>>
>> We used to have one, and it was removed by popular demand
>> (or actually demoted to be printed only in verbose mode, IIRC).
>> I don't feel a need to revisit that decision.
>
> OK, thanks, I had forgotten.
>
To Tom's point, the patch only outputs the new info in verbose mode,
and in that mode a timestamp is indeed already output (it is the
subsequent line in the ASCII dump, actually).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-10-02 22:18:56 | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |
| Previous Message | Bruce Momjian | 2009-10-02 22:11:48 | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |