| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Jim Cox <shakahshakah(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |
| Date: | 2009-10-02 22:18:56 |
| Message-ID: | 200910022218.n92MIuQ01982@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jim Cox wrote:
> On Fri, Oct 2, 2009 at 6:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Tom Lane wrote:
> >> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> > Are we sure we don't want a date/time in the ASCII dump? ?It would
> >> > affect database diffs, but I can see it useful too.
> >>
> >> We used to have one, and it was removed by popular demand
> >> (or actually demoted to be printed only in verbose mode, IIRC).
> >> I don't feel a need to revisit that decision.
> >
> > OK, thanks, I had forgotten.
> >
>
> To Tom's point, the patch only outputs the new info in verbose mode,
> and in that mode a timestamp is indeed already output (it is the
> subsequent line in the ASCII dump, actually).
Thank you.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shakahshakah@gmail.com | 2009-10-02 22:30:00 | 8.5 TODO: any info on "Create dump tool for write-ahead logs..." in PITR section (1.4)? |
| Previous Message | Jim Cox | 2009-10-02 22:16:20 | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |