Re: PATCH: CITEXT 2.0

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: CITEXT 2.0
Date: 2008-07-07 19:03:15
Message-ID: FB5EDA85-66DA-4028-8401-18F35DFFD981@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jul 7, 2008, at 11:54, Alvaro Herrera wrote:

>> Then why shouldn't I use strncmp() for all comparisons?
>
> I have no idea :-) -- because it's not locale-aware perhaps.

Could someone who does have an idea answer these questions:

* Does it need to be locale-aware or not?
* Should I use strncmp() or varstr_cmp() to compare strings?
* Shouldn't it use one or the other, but not both?

Sorry, I'm just confused about the "correct" thing to do here. If
someone who knows the definitive answers could weigh in, I'd be happy
to make the adjustment.

Thanks,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2008-07-07 19:06:08 Re: PATCH: CITEXT 2.0 v2
Previous Message Andrew Hammond 2008-07-07 19:00:12 Re: the un-vacuumable table