pgsql: Don't use "cp -i" in the example WAL archive_command.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't use "cp -i" in the example WAL archive_command.
Date: 2011-06-17 23:14:03
Message-ID: E1QXiEl-00068A-1S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Don't use "cp -i" in the example WAL archive_command.

This is a dangerous example to provide because on machines with GNU cp,
it will silently do the wrong thing and risk archive corruption. Worse,
during the 9.0 cycle somebody "improved" the discussion by removing the
warning that used to be there about that, and instead leaving the
impression that the command would work as desired on most Unixen.
It doesn't. Try to rectify the damage by providing an example that is safe
most everywhere, and then noting that you can try cp -i if you want but
you'd better test that.

In back-patching this to all supported branches, I also added an example
command for Windows, which wasn't provided before 9.0.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/23843d242f00e6597af91d4f4d08b655b2b362ba

Modified Files
--------------
doc/src/sgml/backup.sgml | 25 ++++++++++++++-----------
1 files changed, 14 insertions(+), 11 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-06-17 23:32:34 Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Previous Message Tom Lane 2011-06-17 23:14:02 pgsql: Don't use "cp -i" in the example WAL archive_command.

Browse pgsql-hackers by date

  From Date Subject
Next Message Brendan Jurd 2011-06-17 23:31:41 Fwd: Keywords in pg_hba.conf should be field-specific
Previous Message Bruce Momjian 2011-06-17 22:59:29 Re: pg_upgrade using appname to lock out other users