pgsql: Don't use "cp -i" in the example WAL archive_command.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't use "cp -i" in the example WAL archive_command.
Date: 2011-06-17 23:14:02
Message-ID: E1QXiEk-000683-TP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't use "cp -i" in the example WAL archive_command.

This is a dangerous example to provide because on machines with GNU cp,
it will silently do the wrong thing and risk archive corruption. Worse,
during the 9.0 cycle somebody "improved" the discussion by removing the
warning that used to be there about that, and instead leaving the
impression that the command would work as desired on most Unixen.
It doesn't. Try to rectify the damage by providing an example that is safe
most everywhere, and then noting that you can try cp -i if you want but
you'd better test that.

In back-patching this to all supported branches, I also added an example
command for Windows, which wasn't provided before 9.0.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c1c4f93056ceba4dcbb7779e5215e190587bea90

Modified Files
--------------
doc/src/sgml/backup.sgml | 25 +++++++++++++------------
1 files changed, 13 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-06-17 23:14:03 pgsql: Don't use "cp -i" in the example WAL archive_command.
Previous Message Andrew Dunstan 2011-06-17 22:24:28 pgsql: Set FLEXIBLE_ARRAY_MEMBER to empty for MSVC.