Re: pgsql: Fix crash bug in RestoreSnapshot.

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix crash bug in RestoreSnapshot.
Date: 2016-07-01 13:34:52
Message-ID: CANP8+jLTRNrfjPMhAks7PJNiObDN3zeXGaVtXpC5ivrs0KLqrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 1 July 2016 at 15:04, Robert Haas <rhaas(at)postgresql(dot)org> wrote:

> Fix crash bug in RestoreSnapshot.
>
> If serialized_snapshot->subxcnt > 0 and serialized_snapshot->xcnt == 0,
> the old coding would do the wrong thing and crash. This can happen
> on standby servers.
>
> Report by Andreas Seltenreich. Patch by Thomas Munro, reviewed by
> Amit Kapila and tested by Andreas Seltenreich.
>
> Branch
> ------
> REL9_5_STABLE
>

"This can happen on standby servers"

The commit message doesn't mention, but it applies only to parallel query?

Why then is this backpatched to 9.5?

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2016-07-01 14:00:45 Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Robert Haas 2016-07-01 13:04:30 pgsql: Fix crash bug in RestoreSnapshot.