| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixed redundant i18n strings in json |
| Date: | 2014-08-05 22:05:54 |
| Message-ID: | CAMkU=1wGRVta0fCHfXy4rSTi4ew+DNxAPcjs_AOqQtUESnTtBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 5, 2014 at 9:35 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
> <daniele(dot)varrazzo(at)gmail(dot)com> wrote:
> > I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
> > "argument 1: something is wrong": the string is likely to end up in
> > sentences with other colons so I'd rather use "something is wrong at
> > argument 1".
> >
> > Is the patch attached better?
>
> Looks OK to me. I thought someone else might comment, but since no
> one has, committed.
>
> (As a note for the future, you forgot to update the regression test
> outputs; I took care of that before committing.)
>
I think you missed one of the regression tests, see attached
Thanks,
Jeff
| Attachment | Content-Type | Size |
|---|---|---|
| regression.diffs | application/octet-stream | 931 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-08-05 23:18:23 | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Previous Message | Alvaro Herrera | 2014-08-05 22:03:01 | Re: Append to a GUC parameter ? |