| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixed redundant i18n strings in json |
| Date: | 2014-08-05 16:35:17 |
| Message-ID: | CA+TgmoY6gSoNtrRX3_yRQgVa639PVBUmY+ygYdUL9X7DgHcY4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
<daniele(dot)varrazzo(at)gmail(dot)com> wrote:
> I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
> "argument 1: something is wrong": the string is likely to end up in
> sentences with other colons so I'd rather use "something is wrong at
> argument 1".
>
> Is the patch attached better?
Looks OK to me. I thought someone else might comment, but since no
one has, committed.
(As a note for the future, you forgot to update the regression test
outputs; I took care of that before committing.)
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jerry Sievers | 2014-08-05 18:12:10 | Append to a GUC parameter ? |
| Previous Message | Robert Haas | 2014-08-05 15:55:18 | Re: Spinlocks and compiler/memory barriers |