| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, KONDO Mitsumasa <kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add min and max execute statement time in pg_stat_statement |
| Date: | 2013-10-23 23:51:26 |
| Message-ID: | CAM3SWZRQmoQ6N-xF2c5+6jpRAqLX-QWo2MTKheEp+tfKSC5H-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 23, 2013 at 4:46 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> So you're suggesting that instead of storing the aggregates as we
> currently do, we store a buffer of the last N queries (in normal form)
> and their stats? And then aggregate when the user asks for it?
No, I'm not. I'm suggesting storing the query texts externally, in a
file. They usually use 1024 bytes of shared memory per entry,
regardless of how long the query text is. This would allow
pg_stat_statements to store arbitrarily large query texts, while also
giving us breathing room if we have ambitions around expanding what
pg_stat_statements can (optionally) track.
Having said that, I am still pretty sensitive to bloating pg_stat_statements.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Flower | 2013-10-23 23:55:42 | Re: Add min and max execute statement time in pg_stat_statement |
| Previous Message | Peter Geoghegan | 2013-10-23 23:48:22 | Re: Add min and max execute statement time in pg_stat_statement |