Re: Windows buildfarm animals are still not happy with abbreviated keys patch

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Windows buildfarm animals are still not happy with abbreviated keys patch
Date: 2015-01-26 19:10:20
Message-ID: CAM3SWZQ6cz_P9wGz_U1TrSbYHbncJSBLjjA+3Zmy4JjugNR_mw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 26, 2015 at 11:05 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Now that these issues are fixed and the buildfarm is green again, I'm
> going to try re-enabling this optimization on Windows. My working
> theory is that disabling that categorically was a mis-diagnosis of the
> real problem, and that now that the issues mentioned above are cleaned
> up, it'll just work. That might not be right, but I think it's worth
> a try.

Right. We're only supporting the C locale on Windows. How could
Windows possibly be broken if locale-related functions like strxfrm()
and strcoll() are not even called?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-01-26 19:11:54 Re: Additional role attributes && superuser review
Previous Message Stephen Frost 2015-01-26 19:06:05 Re: Additional role attributes && superuser review