Re: PL/Python: domain over array support

From: Rodolfo Campero <rodolfo(dot)campero(at)anachronics(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Python: domain over array support
Date: 2013-10-28 16:22:29
Message-ID: CAHNrXgEBC7sNmCF+XoTy2FiEQ6nE4RuqZ4qL7HdG-zWLfUe0tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Done, thanks.

2013/10/28 Robert Haas <robertmhaas(at)gmail(dot)com>

> On Sat, Oct 26, 2013 at 9:17 AM, Rodolfo Campero
> <rodolfo(dot)campero(at)anachronics(dot)com> wrote:
> > The attached patch add support of domains over arrays to PL/Python (eg:
> > CREATE DOMAIN my_domain AS integer[]).
> >
> > Basically it just uses get_base_element_type instead of get_element_type
> in
> > plpy_typeio.c, and uses domain_check before returning a sequence as
> array in
> > PLySequence_ToArray whenever appropriate.
> >
> > There's one line I'm not sure about; I modified a switch statement (line
> > 427):
> > switch (element_type ? element_type : getBaseType(arg->typoid))
> > The rationale is that when element_type is set, it is already a base
> type,
> > because there is no support of arrays of domains in PostgreSQL, but this
> may
> > not held true in the future.
>
> Please add your patch here so that it doesn't get forgotten about:
>
> https://commitfest.postgresql.org/action/commitfest_view/open
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-10-28 16:22:56 Re: Darwin: make check fails with "child process exited with exit code 134"
Previous Message Robert Haas 2013-10-28 16:17:48 Re: dsm use of uint64