Re: PL/Python: domain over array support

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Rodolfo Campero <rodolfo(dot)campero(at)anachronics(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Python: domain over array support
Date: 2013-10-28 16:08:18
Message-ID: CA+TgmoYTkDFdSihxbrtwpYK6RmsQwT-9pvmmYBi8sS_OoEv9wA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 26, 2013 at 9:17 AM, Rodolfo Campero
<rodolfo(dot)campero(at)anachronics(dot)com> wrote:
> The attached patch add support of domains over arrays to PL/Python (eg:
> CREATE DOMAIN my_domain AS integer[]).
>
> Basically it just uses get_base_element_type instead of get_element_type in
> plpy_typeio.c, and uses domain_check before returning a sequence as array in
> PLySequence_ToArray whenever appropriate.
>
> There's one line I'm not sure about; I modified a switch statement (line
> 427):
> switch (element_type ? element_type : getBaseType(arg->typoid))
> The rationale is that when element_type is set, it is already a base type,
> because there is no support of arrays of domains in PostgreSQL, but this may
> not held true in the future.

Please add your patch here so that it doesn't get forgotten about:

https://commitfest.postgresql.org/action/commitfest_view/open

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-10-28 16:10:55 Re: RULE regression test fragility?
Previous Message Robert Haas 2013-10-28 16:07:00 Re: RULE regression test fragility?