Re: incorrect handling of the timeout in pg_receivexlog

On Tue, May 22, 2012 at 11:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, May 14, 2012 at 2:24 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Fri, May 11, 2012 at 11:43 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> Should we go down the easy way and just reject connections when the flag is
>>> mismatching between the client and the server (trivial to do - see the
>>> attached patch)?
>>
>> +       char       *tmpparam;
>>
>> You forgot to add "const" before "char", which causes a compile-time warning.
>
> I went ahead and committed this, with this fix and a slight change to
> the message text.

Thanks!

> Hope that's OK with everyone...

What about calling PQfinish() before exit() to avoid "unexpected EOF
connection" error?
Patch attached.

Regards,

--
Fujii Masao