| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: incorrect handling of the timeout in pg_receivexlog |
| Date: | 2012-05-22 14:04:25 |
| Message-ID: | CA+TgmoYqTZhbz3Fnz8Evc23zKWbT5cLxCnHyibe2mn5zBfSdbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 14, 2012 at 2:24 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, May 11, 2012 at 11:43 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Should we go down the easy way and just reject connections when the flag is
>> mismatching between the client and the server (trivial to do - see the
>> attached patch)?
>
> + char *tmpparam;
>
> You forgot to add "const" before "char", which causes a compile-time warning.
I went ahead and committed this, with this fix and a slight change to
the message text.
Hope that's OK with everyone...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-05-22 14:08:47 | Re: Readme of Buffer Management seems to have wrong sentence |
| Previous Message | Tom Lane | 2012-05-22 14:01:58 | Re: Readme of Buffer Management seems to have wrong sentence |