From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
Date: | 2013-11-27 12:32:45 |
Message-ID: | CAFj8pRBnVWmaWnNQTOQQjWHEC=bW=xQgMmuHbkAdntD5hubWdA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
I'll prepare patch
2013/11/27 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> > Actually the IF EXISTS in DROP TABLE now applies to the schema as
> > well. Unfortunately there is currently no consistency across the
> > various DROP commands --- some tolerate a non-existent schema, while
> > others error out.
>
> Yeah. I think now that we've had this discussion, we should make them
> all tolerate a non-existent schema. I'm fine with having that happen
> over a series of patches rather than all at once though.
>
> > Also amongst those that tolerate a non-existent
> > schema, the resulting notices are not consistent --- some report the
> > schema-qualified object name, while others just report the local
> > object name.
>
> Less excited about this part, but on the whole I'd vote for the "schema
> "no_such_schema" does not exist" wording in cases where the schema isn't
> there. The other way is less specific for no very good reason.
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | michael.lancaster | 2013-11-27 15:49:49 | BUG #8633: Assigning to a variable named "current_time" gives wrong output |
Previous Message | jonathan.camile | 2013-11-27 09:26:19 | Re: BUG #8629: Strange resultset when using CTE or a subselect |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2013-11-27 12:45:25 | Re: Incomplete freezing when truncating a relation during vacuum |
Previous Message | Heikki Linnakangas | 2013-11-27 12:25:49 | Re: PL/Python: domain over array support |