| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Date: | 2013-11-27 00:01:38 |
| Message-ID: | 1329.1385510498@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> Actually the IF EXISTS in DROP TABLE now applies to the schema as
> well. Unfortunately there is currently no consistency across the
> various DROP commands --- some tolerate a non-existent schema, while
> others error out.
Yeah. I think now that we've had this discussion, we should make them
all tolerate a non-existent schema. I'm fine with having that happen
over a series of patches rather than all at once though.
> Also amongst those that tolerate a non-existent
> schema, the resulting notices are not consistent --- some report the
> schema-qualified object name, while others just report the local
> object name.
Less excited about this part, but on the whole I'd vote for the "schema
"no_such_schema" does not exist" wording in cases where the schema isn't
there. The other way is less specific for no very good reason.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-11-27 00:34:01 | Re: BUG #8631: invalid page header |
| Previous Message | Dean Rasheed | 2013-11-26 23:56:41 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-11-27 00:19:42 | Re: [GENERAL] pg_upgrade ?deficiency |
| Previous Message | Dean Rasheed | 2013-11-26 23:56:41 | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |