Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Thom Brown <thom(at)linux(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date: 2014-08-25 18:47:10
Message-ID: CAFcNs+r7y_DPstezBxs-LAi0sAFdvNEQVcpPrySwEa7rFSS35w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 25, 2014 at 2:55 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
>
> Fabrízio de Royes Mello wrote:
> > On Sat, Aug 23, 2014 at 8:53 AM, Michael Paquier <
michael(dot)paquier(at)gmail(dot)com>
> > wrote:
> > >
> > > On Sat, Aug 23, 2014 at 3:32 AM, Alvaro Herrera
> > > <alvherre(at)2ndquadrant(dot)com> wrote:
> > > > Great. Pushed. Thanks for the patch.
> > > There is a typo in what has been pushed. Patch attached.
> > >
> >
> > Thanks... I fixed that in my last patch to change 'loggedness' to
> > 'persistence'. Attached.
>
> Thanks, pushed. I also added a comment explaining why it's okay to do
> what we're doing.
>

Thanks...

I'm working on a refactoring to pass down the relpersistence flag to
finish_heap_swap... is this valid for now or I should leave it to another
patch?

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-08-25 18:48:09 Re: Concurrently option for reindexdb
Previous Message Alvaro Herrera 2014-08-25 18:27:59 Re: Specifying the unit in storage parameter