Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Thom Brown <thom(at)linux(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date: 2014-11-15 19:11:16
Message-ID: CAFcNs+p=F0+kzmEr3vwGSvSM95ifm_X5w9L4eRgh6odAWnm5Og@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 15, 2014 at 2:23 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
>
> Michael Paquier wrote:
>
> > Btw, perhaps this diff should be pushed as a different patch as this is
a
> > rather different thing:
> > - if (heapRelation->rd_rel->relpersistence ==
RELPERSISTENCE_UNLOGGED
> > &&
> > + if (indexRelation->rd_rel->relpersistence ==
> > RELPERSISTENCE_UNLOGGED &&
> > !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM)
> > As this is a correctness fix, it does not seem necessary to back-patch
it:
> > the parent relation always has the same persistence as its indexes.
>
> There was an argument for doing it this way that only applies if this
> patch went in, but I can't remember now what it was.
>
> Anyway I pushed the patch after some slight additional changes. Thanks!
>

Thanks!

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-11-15 21:09:18 Re: Patch to support SEMI and ANTI join removal
Previous Message Tomas Vondra 2014-11-15 18:35:53 Re: WIP: multivariate statistics / proof of concept