| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Thom Brown <thom(at)linux(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Date: | 2014-11-15 04:23:58 |
| Message-ID: | 20141115042358.GT1791@alvin.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> Btw, perhaps this diff should be pushed as a different patch as this is a
> rather different thing:
> - if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED
> &&
> + if (indexRelation->rd_rel->relpersistence ==
> RELPERSISTENCE_UNLOGGED &&
> !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM)
> As this is a correctness fix, it does not seem necessary to back-patch it:
> the parent relation always has the same persistence as its indexes.
There was an argument for doing it this way that only applies if this
patch went in, but I can't remember now what it was.
Anyway I pushed the patch after some slight additional changes. Thanks!
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-11-15 04:27:30 | Re: New storage parameter pages_per_range not mentioned in CREATE INDEX doc |
| Previous Message | Alvaro Herrera | 2014-11-15 04:22:32 | Re: Useless dead struct in parse_func.h |