Re: RFC: ExecNodeExtender

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: ExecNodeExtender
Date: 2013-06-07 07:23:45
Message-ID: CADyhKSWME4enF+MP99wEMkVCGW2MHaxisCjz7Dd+ACqbZpvOUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/6/6 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Jun 4, 2013 at 2:50 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>> Also, I don't think ExecNodeExtender is not a good naming, because it
>> is a bit long and
>> abbreviation (ENE?) is hard to imagine the feature. Please give this
>> feature a cool and
>> well understandable name.
>
> I agree that "Extender" doesn't sound right. "Extension" would
> probably be the right part of speech, but that has multiple meanings
> that might confuse the issue. (Does CREATE EXTENSION take the
> relation extension lock? And don't forget PostgreSQL extensions to
> the SQL standard!)
>
> I'm wondering if we ought to use something like "Custom" instead, so
> that we'd end up with ExecInitCustom(), ExecCustom(), ExecEndCustom().
> I think that would make it more clear to the casual reader that this
> is a hook for user-defined code.
>
> Other bike-shedding?
>
Thanks for your suggestion. I also prefer the naming with "Custom" and
relevant function names, much rather than "Extender".
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hari Babu 2013-06-07 07:46:33 system catalog pg_rewrite column ev_attr document description problem
Previous Message Amit Kapila 2013-06-07 06:28:14 Re: Partitioning performance: cache stringToNode() of pg_constraint.ccbin