Re: RFC: ExecNodeExtender

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: ExecNodeExtender
Date: 2013-06-06 16:26:14
Message-ID: CA+TgmobuXjHKEP67rHu963Vsp4hG=Ag49sFN5b7GDMZs48xHsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 4, 2013 at 2:50 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> Also, I don't think ExecNodeExtender is not a good naming, because it
> is a bit long and
> abbreviation (ENE?) is hard to imagine the feature. Please give this
> feature a cool and
> well understandable name.

I agree that "Extender" doesn't sound right. "Extension" would
probably be the right part of speech, but that has multiple meanings
that might confuse the issue. (Does CREATE EXTENSION take the
relation extension lock? And don't forget PostgreSQL extensions to
the SQL standard!)

I'm wondering if we ought to use something like "Custom" instead, so
that we'd end up with ExecInitCustom(), ExecCustom(), ExecEndCustom().
I think that would make it more clear to the casual reader that this
is a hook for user-defined code.

Other bike-shedding?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-06-06 16:28:18 Re: Statement timeout logging
Previous Message Gurjeet Singh 2013-06-06 15:13:35 Re: Processing long AND/OR lists