| From: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Function array_agg(array) |
| Date: | 2014-10-27 07:12:31 |
| Message-ID: | CACQjQLrUcWYyYHSRw6K3i4QhOvhDLO02OMC6mCdmQUU_cC4e2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2014-10-27 9:11 GMT+07:00 Ali Akbar <the(dot)apaan(at)gmail(dot)com>:
>
> 2014-10-27 1:38 GMT+07:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>
>> Hi
>>
>> My idea is using new ArrayBuilder optimized for building multidimensional
>> arrays with own State type. I think so casting to ArrayBuildState is base
>> of our problems, so I don't would to do. Code in array_agg_* is simple,
>> little bit more complex code is in nodeSubplan.c. Some schematic changes
>> are in attachments.
>>
>
> Thanks! The structure looks clear, and thanks for the example on
> nodeSubplan.c. I will restructure the v10 of the patch to this structure.
>
Patch attached.
Regards,
--
Ali Akbar
| Attachment | Content-Type | Size |
|---|---|---|
| array_agg_anyarray-11.patch | text/x-patch | 31.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2014-10-27 07:24:24 | Re: DISTINCT with btree skip scan |
| Previous Message | Kouhei Kaigai | 2014-10-27 06:35:22 | Re: [v9.5] Custom Plan API |