Re: Function array_agg(array)

Hi

I did some minor changes in code

* move tests of old or new builder style for array sublink out of main
cycles
* some API simplification of new builder - we should not to create
identical API, mainly it has no sense

Regards

Pavel Stehule

2014-10-27 8:12 GMT+01:00 Ali Akbar <the(dot)apaan(at)gmail(dot)com>:

> 2014-10-27 9:11 GMT+07:00 Ali Akbar <the(dot)apaan(at)gmail(dot)com>:
>
>>
>> 2014-10-27 1:38 GMT+07:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>>
>>> Hi
>>>
>>> My idea is using new ArrayBuilder optimized for building
>>> multidimensional arrays with own State type. I think so casting to
>>> ArrayBuildState is base of our problems, so I don't would to do. Code in
>>> array_agg_* is simple, little bit more complex code is in nodeSubplan.c.
>>> Some schematic changes are in attachments.
>>>
>>
>> Thanks! The structure looks clear, and thanks for the example on
>> nodeSubplan.c. I will restructure the v10 of the patch to this structure.
>>
>
> Patch attached.
>
> Regards,
> --
> Ali Akbar
>