From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 9.5 CF1 |
Date: | 2014-06-18 15:38:48 |
Message-ID: | CABUevExnQu5xgObAYg777vyWnN+AAdfEHoYVcOBHqPapsX6_Gw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 17, 2014 at 6:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Robert Haas wrote:
> >> On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
> wrote:
> >>> P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
> >>> easier to keep track of them.
>
> >> I and, I believe, various other people hate that style, because at
> >> least in Gmail, it breaks the threading. It is much easier to find
> >> things if they are all posted on one thread.
>
> > Yes, please don't do that. A simple, normal reply to the message that
> > submits the patch is much better from my point of view as a subsequent
> > reviewer and committer.
>
> Worth noting also is that Magnus is working on a new version of the
> commitfest app that will be able to automatically keep track of threads
> about patches --- so long as they *are* threads according to our mailing
> list archives. I'm not sure if the archives recognize replies with a
> changed Subject: as being the same thread or not.
>
The archives code does threading based on the headers (in-reply-to and
references, in priority order). It completely ignores the subject when it
comes to the threading.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2014-06-18 15:41:06 | Is analyze_new_cluster.sh still useful? |
Previous Message | Andrew Dunstan | 2014-06-18 15:31:21 | buildfarm client release 4.13 |