| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logging WAL when updating hintbit |
| Date: | 2013-12-03 03:02:36 |
| Message-ID: | CAB7nPqRdWQOs+pLZZgWYsV4tLr5tBLGOLMFOudD3Vz=x2rkuLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 3, 2013 at 11:57 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Dec 3, 2013 at 1:08 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> As long as it was set at
>> the time the master last entered read-write mode (which is what the
>> XLOG_PARAMETER_CHANGE stuff does) you should be fine, unless of course
>> I haven't had enough caffeine this morning, which is certainly
>> possible.
> Indeed, I forgot this code path. Completing XLogReportParameters for
> saving the state and xlog_redo for replay would be enough.
Wait a minute, I retract this argument. By using this method a master
server would be able to produce WAL files with inconsistent hint bit
data when they are replayed if log_hint_bits is changed after a
restart of the master.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2013-12-03 03:15:36 | Re: Status of FDW pushdowns |
| Previous Message | Michael Paquier | 2013-12-03 02:57:09 | Re: Logging WAL when updating hintbit |