| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
| Subject: | Re: tracking commit timestamps |
| Date: | 2014-11-04 08:29:04 |
| Message-ID: | CAB7nPqR-AZgFUn4yEnyHGh+q0dJY3QomrL-eUuyPEg_EJRyi3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Tue, Nov 4, 2014 at 5:23 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> On 2014-11-04 17:19:18 +0900, Michael Paquier wrote:
> > 5) Reading the code, TransactionTreeSetCommitTimestamp is always called
> > with do_xlog = false, making that actually no timestamps are WAL'd...
> Hence
> > WriteSetTimestampXlogRec is just dead code with the latest version of the
> > patch. IMO, this should be always WAL-logged when track_commit_timestamp
> is
> > on.
>
> It's callable via a 'extern' function. So, I'd not consider it dead. And
> the WAL logging is provided by xact.c's own WAL logging - it always does
> the corresponding committs calls.
>
The code path is unused. We'd better make the XLOG record mandatory if
tracking is enabled, as this information is useful on standbys as well.
> > 7) pg_xlogdump has no support for RM_COMMITTS_ID, something that would be
> > useful for developers.
>
> What do you mean by that? There's the corresponding rmgrdesc.c support I
> think?
>
Oops sorry. I thought there was some big switch in pg_xlogdump when writing
this comment. Yeah that's fine.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2014-11-04 08:30:21 | Re: Let's drop two obsolete features which are bear-traps for novices |
| Previous Message | Michael Paquier | 2014-11-04 08:25:15 | Re: tracking commit timestamps |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-11-04 08:56:31 | Re: tracking commit timestamps |
| Previous Message | Michael Paquier | 2014-11-04 08:25:15 | Re: tracking commit timestamps |