| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: option -T in pg_basebackup doesn't work on windows |
| Date: | 2014-08-22 08:35:15 |
| Message-ID: | CAA4eK1LrWp4L_kFEYOk=tVnXCRzM+L1nhK9yZT4n-0VPqSag0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 22, 2014 at 1:00 PM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
wrote:
> On 08/22/2014 07:08 AM, Amit Kapila wrote:
>> Today morning, I realised that there is one problem with the
>> patch I sent yesterday and the problem is that incase user
>> has not given -T option, it will not be able to create the symlink
>> for appropriate path. Attached patch fix this issue.
>
>
> Thanks, committed with minor changes:
Thank you. One minor point I observed is that in comments below,
you have used --tablespace as option name rather than
--tablespace-mapping, is it intentional?
+ * the location of a tablespace. Apply any tablespace
+ * mapping given on the command line (--tablespace).
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Raiskup | 2014-08-22 08:52:12 | Re: pg_upgrade: allow multiple -o/-O options |
| Previous Message | Michael Paquier | 2014-08-22 07:58:47 | Re: Removing dependency to wsock32.lib when compiling code on WIndows |