| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: option -T in pg_basebackup doesn't work on windows |
| Date: | 2014-08-22 10:49:00 |
| Message-ID: | 53F7201C.2030609@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/22/2014 11:35 AM, Amit Kapila wrote:
> On Fri, Aug 22, 2014 at 1:00 PM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
> wrote:
>> On 08/22/2014 07:08 AM, Amit Kapila wrote:
>>> Today morning, I realised that there is one problem with the
>>> patch I sent yesterday and the problem is that incase user
>>> has not given -T option, it will not be able to create the symlink
>>> for appropriate path. Attached patch fix this issue.
>>
>>
>> Thanks, committed with minor changes:
>
> Thank you. One minor point I observed is that in comments below,
> you have used --tablespace as option name rather than
> --tablespace-mapping, is it intentional?
>
> + * the location of a tablespace. Apply any tablespace
> + * mapping given on the command line (--tablespace).
Sorry, my mistake. Fixed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2014-08-22 11:55:15 | Re: add line number as prompt option to psql |
| Previous Message | Jeevan Chalke | 2014-08-22 10:21:18 | Re: Re: proposal: ignore null fields in not relation type composite type based constructors |