From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PostgreSQL in Windows console and Ctrl-C |
Date: | 2014-04-13 04:51:37 |
Message-ID: | CAA4eK1JV4uhFKBpJWuyLN9anY4DNkkes=LtUwCZXcC0MC+6FZA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Apr 12, 2014 at 12:36 PM, Christian Ullrich
<chris(at)chrullrich(dot)net> wrote:
> * From: Amit Kapila
>
>> Another thing to decide about this fix is that whether it is okay to fix
>> it for CTRL+C and leave the problem open for CTRL+BREAK?
>> (The current option used (CREATE_NEW_PROCESS_GROUP) will handle only
>> CTRL+C).
>
> Below is a new (right now very much proof-of-concept) patch to replace
> my earlier one. It has the same effect on Ctrl-C the change to pg_ctl had,
> and additionally ignores Ctrl-Break as well.
This fix won't allow CTRL+C for other cases like when server is started
directly with postgres binary.
./postgres -D <data_dir_path>
I think this doesn't come under your original complaint and as such I
don't see any problem in allowing CTRL+C for above case.
One another way could be to use CREATE_NEW_CONSOLE instead of
CREATE_NEW_PROCESS_GROUP in you previous fix, but I am not
sure if it's acceptable to users to have a new console window for server.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2014-04-13 04:52:12 | Re: WIP patch (v2) for updatable security barrier views |
Previous Message | Stephen Frost | 2014-04-13 04:42:30 | pgsql: Add ANALYZE into regression tests |