Re: [PATCH] Regression tests in windows ignore white space

On Mon, Dec 30, 2013 at 11:08 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Mon, Dec 30, 2013 at 6:02 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
>> For Windows build, I am using whatever latest Git provides rather than
>> downloading
>> individual components which might not be good, but I find it
>> convenient. The latest
>> Git (1.8.4) download on windows still provides 2.7, which is the
>> reason I am on older
>> version. However I agree that it is better to use latest version.
>
>
> It looks like the diff version I'm using is from msys and msys is what is in
> my search path rather than the git\bin path. To be honest I didn't realise
> that git for windows came with bison and flex, (at least I see bison.exe and
> flex.exe in the git\bin path.. I don't remember me putting them there)

Yes, git for windows came with bison,flex, etc required for PG build.

> I don't seem to even have git\bin in my %path% environment variable at all,
> so all those tools are being picked up from the msys path. I'd need to
> remind myself about the msys install process, but since we're already saying
> in the docs that msys should be installed,
I think it is one of the ways of set up on Windows, not every user
uses from msys.

> then would the fix for this not
> just be as simple as my patch plus a note in the docs to say to ensure
> msys\bin occurs before git\bin in the %path% environment var, minimum
> supported diff version is 2.8.

To be honest, I am also not fully aware of the project policy in such
a matter where we have to mention the minimum version of dependent
executable (diff). I request some senior members to please let us know
whether we can make PG dependent on diff version >= 2.8 (atleast
for windows), as there are some of the options which are not available
in older versions.

Another option could be that if version of diff available is >= 2.8, then
use '--strip-trailing-cr', else use existing option '-w', but not
sure if it will
serve the purpose completely.

> Did you install msys? if so does it have a later version of diff?
No.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com