Re: [PATCH] Store Extension Options

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Store Extension Options
Date: 2014-03-13 01:38:24
Message-ID: CA+U5nMJmqui1Gh7GKz6mFU4E-zRU5+E90aNqW22JLzVtqqtt1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12 March 2014 22:58, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> I don't like the idea of using reloptions to let people attach
> arbitrary unvalidated settings to tables.

I respect your opinion. If you disagree, don't use them. Same as is
possible for RULEs etc.

> I consider the way things
> work with GUCs to be a bug, not a feature, and definitely not
> something I want to propagate into every other area of the system
> where the underlying storage format happens to allow it.

Experience was that requiring validation made things more brittle,
which is why we relaxed things a few releases ago. Opinions are one
thing, experience is quite another.

> I kind of think that this is too half-baked for 9.4 and we ought to
> punt it to 9.5.

No, its fully functional, apart from the requirement for validation
which is imposed upon this patch.

I'm not sure why this is being blocked. This is a community
contribution that seeks to improve everybody's options. Blocking it
does *nothing* to prevent individual extensions from providing
table-level options - we give them freedom to do whatever the hell
they want. Validation is a pipe dream, not *ever* an achievable
reality. Blocking is just exercise of a veto for nobody's gain.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-03-13 02:14:06 Re: [PATCH] Store Extension Options
Previous Message David Johnston 2014-03-13 01:37:35 Re: Bug: Fix Wal replay of locking an updated tuple (WAS: Re: 9a57858f1103b89a5674f0d50c5fe1f756411df6)