From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Why does WAL_DEBUG macro need to be defined by default? |
Date: | 2011-10-07 14:00:01 |
Message-ID: | CA+TgmobcLLvu47HmaVY71HPcN-PkjVJvbRSg-XB2icmkJeZC3Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 7, 2011 at 5:19 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> I found that by default WAL_DEBUG macro has been defined in
> 9.2dev and 9.1. I'm very surprised at this. Why does WAL_DEBUG
> need to be defined by default? The performance overhead
> introduced by WAL_DEBUG is really vanishingly low?
>
> WAL_DEBUG was defined in the following commit:
> 53dbc27c62d8e1b6c5253feba04a5094cb8fe046
>
> ----------------------
> Support unlogged tables.
>
> The contents of an unlogged table are WAL-logged; thus, they are not
> available on standby servers and are truncated whenever the database
> system enters recovery. Indexes on unlogged tables are also unlogged.
> Unlogged GiST indexes are not currently supported.
> ----------------------
Oh, dear. That was a mistake on my part. :-(
The funny thing is that I've been thinking all of these months about
how convenient it is that we defined WAL_DEBUG in debug builds, not
realizing that (1) we were defining it all the time, not just in debug
builds and (2) I was the one who accidentally did that.
Sorry, all.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Yeb Havinga | 2011-10-07 14:56:21 | Re: [REVIEW] Patch for cursor calling with named parameters |
Previous Message | Robert Haas | 2011-10-07 13:53:53 | Re: alter table only ... drop constraint broken in HEAD |