Re: Planning time in explain/explain analyze

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Planning time in explain/explain analyze
Date: 2013-12-24 04:09:16
Message-ID: CA+TgmobJFb+yd-NeXD=QHaTdfFS1bqruAu4DD-=_VQBO90zfvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 23, 2013 at 10:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Dec 23, 2013 at 9:54 PM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>>> Yeah, forgot to mention that we need some way to disable it in the tests.
>>> Either by not having it included in EXPLAIN or by adding an option to turn
>>> it off. Any suggestion on which would be preferable?
>
>> I would be tempted to display it only if (COSTS OFF) is not given.
>
> Yeah. The alternatives seem to be:
>
> 1. Change a lot of regression tests. This would be a serious PITA,
> not so much for the one-time cost as for every time we needed to
> back-patch a regression test that includes explain output. -1.
>
> 2. Don't display the planning time by default, necessitating a new
> PLANNING_TIME ON option. This has backwards compatibility to
> recommend it, but not much else.
>
> 3. Let COSTS OFF suppress it.

Another option would be to not display it by default, but make VERBOSE
show it. However, I think making it controlled by COSTS is a better
fit.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-12-24 04:58:29 Re: Logging WAL when updating hintbit
Previous Message Tom Lane 2013-12-24 03:47:49 Re: Planning time in explain/explain analyze