Re: Review of pg_archivecleanup -x option patch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review of pg_archivecleanup -x option patch
Date: 2012-03-08 13:25:12
Message-ID: CA+Tgmob4NdTWAWy=bX5woT2jAYnGA8AxbE1cRggJmitX1_cNbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 12, 2012 at 9:19 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> The smaller step of automatically stripping the specified suffix from the
> input file name, when it matches the one we've told the program to expect,
> seems like a usability improvement unlikely to lead to bad things though.
>  I've certainly made the mistake you've shown when using the patched version
> of the program myself, just didn't think about catching and correcting it
> myself before.  We can rev this to add that feature and resubmit easily
> enough, will turn that around soon.

This change seems plenty small enough to slip in even at this late
date, but I guess we're lacking a new version of the patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2012-03-08 13:31:32 Re: pg_stat_statements and planning time
Previous Message Robert Haas 2012-03-08 13:20:02 Re: Avoiding shutdown checkpoint at failover