| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: mvcc catalo gsnapshots and TopTransactionContext |
| Date: | 2013-10-07 19:02:36 |
| Message-ID: | CA+Tgmoam4Exh2KLbqRyR8ijeRBqnQApXo7KQSaTEwpwgb45b5w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 4, 2013 at 3:20 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-10-04 15:15:36 -0400, Robert Haas wrote:
>> Andres, are you (or is anyone) going to try to fix this assertion failure?
>
> I think short term replacing it by IsTransactionOrTransactionBlock() is
> the way to go. Entirely restructuring how cache invalidation in the
> abort path works is not a small task.
Well, if we're going to go that route, how about something like the
attached? I included the assert-change per se, an explanatory
comment, and the test case that Noah devised to cause the current
assertion to fail.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| weaken-searchcatcache-assert.patch | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-10-07 19:06:42 | Re: Patch: FORCE_NULL option for copy COPY in CSV mode |
| Previous Message | Kevin Grittner | 2013-10-07 17:26:47 | drop-index-concurrently-1 on master fails at serializable |