| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: mvcc catalo gsnapshots and TopTransactionContext |
| Date: | 2013-10-07 20:55:23 |
| Message-ID: | 20131007205523.GI15202@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-10-07 15:02:36 -0400, Robert Haas wrote:
> On Fri, Oct 4, 2013 at 3:20 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > On 2013-10-04 15:15:36 -0400, Robert Haas wrote:
> >> Andres, are you (or is anyone) going to try to fix this assertion failure?
> >
> > I think short term replacing it by IsTransactionOrTransactionBlock() is
> > the way to go. Entirely restructuring how cache invalidation in the
> > abort path works is not a small task.
>
> Well, if we're going to go that route, how about something like the
> attached? I included the assert-change per se, an explanatory
> comment, and the test case that Noah devised to cause the current
> assertion to fail.
Sounds good to me. Maybe add a comment to the added regression test
explaining it tests invalidation processing at xact abort?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2013-10-07 21:02:20 | Re: Re: custom hash-based COUNT(DISTINCT) aggregate - unexpectedly high memory consumption |
| Previous Message | Heikki Linnakangas | 2013-10-07 20:49:06 | Re: SSI freezing bug |