| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Fix pg_isolation_regress to work outside its build directory. |
| Date: | 2013-11-12 16:29:50 |
| Message-ID: | CA+TgmoaVjLMe0e+Qi-aR3LsOKn2zJY2s8PgmoeD5kaL-uO6Fcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Nov 12, 2013 at 7:05 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> The only hack I currently can think of is to store argv[0] in a global
>> variable and to run the find_other_exec() in the first run through
>> isolation_start_test() :/.
>
> A patch to that end attached.
>
> Alternatively we could add a "startup_function startup" argument to
> regression_main() that's called later, when the environment is setup.
That might be a better long-term solution, although I'll defer to the
opinions of people who have worked on this code more than I have. But
I've committed this for now, in the hopes of making the buildfarm
green again.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-11-12 16:31:06 | Re: pgsql: Try again to make pg_isolation_regress work its build directory. |
| Previous Message | Robert Haas | 2013-11-12 16:29:48 | pgsql: Try again to make pg_isolation_regress work its build directory. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-11-12 16:29:51 | Re: What's needed for cache-only table scan? |
| Previous Message | Stephen Frost | 2013-11-12 16:25:03 | Re: Errors on missing pg_subtrans/ files with 9.3 |