Re: tracking commit timestamps

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-12-03 21:18:11
Message-ID: CA+TgmoZ_EF2LOe3DdYVtQCJqMvKY9xgp1gDP2149VPrtxTidxg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Wed, Dec 3, 2014 at 2:36 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Alvaro Herrera wrote:
>> Robert Haas wrote:
>> > I'm kind of disappointed that, in spite of previous review comments,
>> > this got committed with extensive use of the CommitTs naming. I think
>> > that's confusing, but it's also something that will be awkward if we
>> > want to add other data, such as the much-discussed commit LSN, to the
>> > facility.
>>
>> I never saw a comment that CommitTs was an unwanted name. There were
>> some that said that committs wasn't liked because it looked like a
>> misspelling, so we added an underscore -- stuff in lower case is
>> commit_ts everywhere. Stuff in camel case didn't get the underscore
>> because it didn't seem necessary. But other than that issue, the name
>> wasn't questioned, as far as I'm aware.
>
> I found one email where you said you didn't like committs and preferred
> commit_timestamp instead. I don't see how making that change would have
> made you happy wrt the concern you just expressed.

Fair point.

I'm still not sure we got this one right, but I don't know that I want
to spend more time wrangling about it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2014-12-03 21:31:39 postgres_fdw does not see enums
Previous Message Peter Geoghegan 2014-12-03 21:05:25 Re: B-Tree support function number 3 (strxfrm() optimization)

Browse pgsql-www by date

  From Date Subject
Next Message Fujii Masao 2014-12-04 03:08:18 Re: tracking commit timestamps
Previous Message Alvaro Herrera 2014-12-03 19:36:47 Re: tracking commit timestamps