Re: tracking commit timestamps

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-12-03 19:36:47
Message-ID: 20141203193647.GC1737@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Alvaro Herrera wrote:
> Robert Haas wrote:

> > I'm kind of disappointed that, in spite of previous review comments,
> > this got committed with extensive use of the CommitTs naming. I think
> > that's confusing, but it's also something that will be awkward if we
> > want to add other data, such as the much-discussed commit LSN, to the
> > facility.
>
> I never saw a comment that CommitTs was an unwanted name. There were
> some that said that committs wasn't liked because it looked like a
> misspelling, so we added an underscore -- stuff in lower case is
> commit_ts everywhere. Stuff in camel case didn't get the underscore
> because it didn't seem necessary. But other than that issue, the name
> wasn't questioned, as far as I'm aware.

I found one email where you said you didn't like committs and preferred
commit_timestamp instead. I don't see how making that change would have
made you happy wrt the concern you just expressed.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-12-03 21:05:25 Re: B-Tree support function number 3 (strxfrm() optimization)
Previous Message Claudio Freire 2014-12-03 19:29:37 Re: Removing INNER JOINs

Browse pgsql-www by date

  From Date Subject
Next Message Robert Haas 2014-12-03 21:18:11 Re: tracking commit timestamps
Previous Message Alvaro Herrera 2014-12-03 18:11:32 Re: tracking commit timestamps