Re: Publish checkpoint timing and sync files summary data to pg_stat_bgwriter

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Publish checkpoint timing and sync files summary data to pg_stat_bgwriter
Date: 2012-04-05 18:07:20
Message-ID: CA+TgmoZVTmgiFnStwyu-eWAJC34fi2du=DoxH2pFCNt2p193qg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 5, 2012 at 9:05 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 3 April 2012 12:11, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Well, for 9.2, I am asking that you rip all that stuff out of the
>> patch altogether so we can focus on the stuff that was in the original
>> patch.
>
> Given how we're pushed for time, I'm inclined to agree that that is
> the best course of action.
>
> Attached revision does not attempt to do anything with strategy
> writes/allocations.

I have committed this after extensive revisions. I removed the
sync_files count, since no one ever explained what that was good for.
I renamed a bunch of things so that it was clear that these stats were
referring to checkpoints rather than anything else. I moved the
documentation to what I believe to be the correct place. I fixed a
few other assorted things, too, and reverted a couple hunks that
didn't seem to me to be adding anything.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-04-05 18:10:34 Re: Last gasp
Previous Message Robert Haas 2012-04-05 18:00:53 Re: Last gasp