| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Christian Kruse <christian(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Date: | 2014-02-11 14:15:45 |
| Message-ID: | CA+TgmoYF-jf59+pFAdWezEi7+pEC5xns2_dUngR6ye6NJ9KDnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 7, 2014 at 4:34 AM, Christian Kruse
<christian(at)2ndquadrant(dot)com> wrote:
> attached you will find a new version with the following issues
> resolved:
>
> - use backend ID once again for getting the xid and xmin
> - use <xref> instead of <link> in documentation
> - rename fields to backend_xid and backend_xmin
This looks mostly good but it doesn't address this point, from one of
my earlier emails:
If I understand correctly, modifying PgBackendStatus adds additional
fields to the shared memory data structure that are never used and
will be returned by functions like pgstat_fetch_stat_beentry()
unitialized. That seems both inefficient and a pitfall for the
unwary.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-02-11 15:04:29 | Re: narwhal and PGDLLIMPORT |
| Previous Message | Andres Freund | 2014-02-11 13:07:57 | Re: Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease |