| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Christian Kruse <christian(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Date: | 2014-02-05 17:43:31 |
| Message-ID: | CA+TgmoY4RMBpN9eUO6XW_MuQLojHRF50cZr0L456H5nEryQJxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 3, 2014 at 6:47 AM, Christian Kruse
<christian(at)2ndquadrant(dot)com> wrote:
> [ new patch ]
Is there some compelling reason not to write the documentation link as
<xref linkend="guc-hot-standby-feedback"> rather than using <link>?
It feels weird to me that the new columns are called transactionid and
xmin. Why not xid and xmin?
If I understand correctly, modifying PgBackendStatus adds additional
fields to the shared memory data structure that are never used and
will be returned by functions like pgstat_fetch_stat_beentry()
unitialized. That seems both inefficient and a pitfall for the
unwary.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-02-05 17:48:07 | Re: jsonb and nested hstore |
| Previous Message | Robert Haas | 2014-02-05 17:36:42 | Re: Misaligned BufferDescriptors causing major performance problems on AMD |