| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Date: | 2011-01-22 17:20:20 |
| Message-ID: | AANLkTin0aO9qZm2S++zfnc=xvYDi=GELx_e-0PPAQCBh@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Jan 22, 2011 at 18:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> This appears to have broken Solaris, Unixware and MSVC builds.
>
> BTW, the MSVC problem appears to stem from failure to include libpgport
> when linking pg_test_fsync. I imagine this requires a fix in the MSVC
> build scripts.
Yup, fixed and pushed.
I still get:
pg_test_fsync.c
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101: 'ops'
: unreferenced local variable
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
'writes' : unreferenced local variable
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
'tmpfile' : unreferenced local variable
ISTM that the declaration of variables should be moved inside the #ifdef, no?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-22 17:26:58 | pgsql: Suppress unused-variables warning when OPEN_SYNC_FLAG isn't defi |
| Previous Message | Magnus Hagander | 2011-01-22 17:18:51 | pgsql: Link libpgport into pg_test_fsync on msvc |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-22 17:28:58 | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Previous Message | Tom Lane | 2011-01-22 17:12:06 | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |