| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Date: | 2011-01-22 17:28:58 |
| Message-ID: | 27379.1295717338@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> I still get:
> pg_test_fsync.c
> 1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101: 'ops'
> : unreferenced local variable
> 1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
> 'writes' : unreferenced local variable
> 1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
> 'tmpfile' : unreferenced local variable
> ISTM that the declaration of variables should be moved inside the #ifdef, no?
Yeah, I independently came to the same conclusion ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-22 20:01:54 | pgsql: More pg_test_fsync fixups. |
| Previous Message | Tom Lane | 2011-01-22 17:26:58 | pgsql: Suppress unused-variables warning when OPEN_SYNC_FLAG isn't defi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-22 18:38:48 | plpython versus gcc 4.5.x |
| Previous Message | Magnus Hagander | 2011-01-22 17:20:20 | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |