| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Greg Smith <greg(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Per-column collation |
| Date: | 2010-12-16 11:03:53 |
| Message-ID: | AANLkTikHy6S6hTF1Yf1o+3igA2XV7E5y25fXzY-QUCC0@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 16, 2010 at 19:37, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> I just updated the CF app to track Peter's latest update, which remains
> untested by anyone else for whether it fixes all the issues brought up. It
> would be nice to get a re-review to confirm things are still working in
> advance of CF 2011-01.
Sorry, I don't have enough time to review it. Also, multiple reviewers
using different kinds of settings would be preferred for such feature.
# We might need "previous reviewers" and "active reviewers" in commit-fest
# app. Or, should non-active reviewers delete their names?
I tested it in program-level, but the code-level review is still needed.
I'm worried about whether "no holes" checks are required in COLLATE
hand-off from function to function. If so, the review will be a harder
work than the case where the framework guarantee the hand-off.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2010-12-16 11:11:38 | Re: Per-column collation |
| Previous Message | Itagaki Takahiro | 2010-12-16 10:46:20 | Re: Default mode for shutdown |