Re: FOR KEY LOCK foreign keys

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Subject: Re: FOR KEY LOCK foreign keys
Date: 2011-02-15 21:15:38
Message-ID: AANLkTikHp3cb+pB_d1ROGhFsTaoqKUbQMVM3iVA44v3J@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 14, 2011 at 6:49 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Excerpts from Marti Raudsepp's message of lun feb 14 19:39:25 -0300 2011:
>> On Fri, Feb 11, 2011 at 09:13, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> > The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've
>> > attached the rebased patch that I used for review.  For anyone following along,
>> > all the interesting hunks touch heapam.c; the rest is largely mechanical.  A
>> > "diff -w" patch is also considerably easier to follow.
>>
>> Here's a simple patch for the RelationGetIndexAttrBitmap() function,
>> as explained in my last post. I don't know if it's any help to you,
>> but since I wrote it I might as well send it up. This applies on top
>> of Noah's rebased patch.
>
> Got it, thanks.
>
>> I did some tests and it seems to work, although I also hit the same
>> visibility bug as Noah.
>
> Yeah, that bug is fixed with the attached, though I am rethinking this
> bit.

I am thinking that the statute of limitations has expired on this
patch, and that we should mark it Returned with Feedback and continue
working on it for 9.2. I know it's a valuable feature, but I think
we're out of time.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2011-02-15 21:32:36 Re: FOR KEY LOCK foreign keys
Previous Message Simon Riggs 2011-02-15 21:15:18 Re: XMin Hot Standby Feedback patch