Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)
Date: 2010-12-16 14:24:22
Message-ID: AANLkTi=DHf3+7Va6sVp78R2RU+8A_avk4=cSTbNZnA3C@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 16, 2010 at 15:07, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Dec 16, 2010 at 8:01 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> We use the existance of the "crashdumps" directory as an indication we
>> want crashdumps. That's fine when the system is up. But what if we
>> crash *in the postmaster before we have done chdir()*?
>>
>> Should we perhaps instead define a subdirectory of *where the .EXE
>> file is*, and dump the file there?
>
> That seems pretty ugly, for a pretty marginal case.  The number of
> crashes that are going to happen in the postmaster before we've done
> chdir() should be extremely small, especially if we're talking about
> crashes in the field rather than during development.  How about adding
> a command-line option to force a dump to be written in $CWD whether a
> crashdumps directory exists or not?

Is that less ugly? ;)

But yes, we are talking about in the field, so it's fairly small. But
any crash during guc loading for example would go there, I think?

We can do such a commandline. We don't have any platform-specific
commandline options today. Is that something we've intentionally
avoided, or just not needed before?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2010-12-16 14:44:11 Re: [HACKERS] getting composite types info from libpq
Previous Message Andres Freund 2010-12-16 14:18:20 Re: mvcc & DML on the same row